FIX: add guardrails for too big tk figures #17470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
May 21, 2020
|
Could we just have a warning for > 1000 inches? Ie your figure is gigantic, and the backend may have difficulty? |
|
In some combinations of tk and xserver we need to actually prevent the call to tk so we need more than a warning. I'm hesitant to put a non externally motivated hard maximum size (8MB is big enough for anyone!). |
|
That’s why I suggested a warning. In this case the user was accidentally setting the fig size to something crazy, and a warning would have helped debug the problem. I don’t think we can or should add different guard rails for every system and backend combination |
|
Can we do the warnings in a follow on? |
jklymak
approved these changes
Jun 1, 2020
Depending on the version of xserver creating a too big tk window either corrupts xorg (!) or causes the process to exit. This adds a guard rail that will convert this into a python exception instead. closes matplotlib#17460
timhoffm
reviewed
Jun 3, 2020
Co-authored-by: Tim Hoffmann <[email protected]>
QuLogic
approved these changes
Jun 3, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jun 3, 2020
QuLogic
added a commit
that referenced
this pull request
Jun 4, 2020
…470-on-v3.2.x Backport PR #17470 on branch v3.2.x (FIX: add guardrails for too big tk figures)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Depending on the version of xserver creating a too big tk window
either corrupts xorg (!) or causes the process to exit. This adds a
guard rail that will convert this into a python exception instead.
closes #17460
PR Checklist
Not sure if it is worth adding a test for this as it is such an out-there condition.