Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Simplify handling of fontproperties=None. #17486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2020
Merged

Simplify handling of fontproperties=None. #17486

merged 1 commit into from
May 22, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 22, 2020

... by moving support for it (building a default FontProperties()) to
the generic constructor FontProperties._from_any.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

timhoffm
timhoffm approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bonus points if you add a docstring to _from_any(). Even though it's private, as a contributor and reader of the code, it's cumbersome to find out what it accepts, and what the effect is.

@anntzer
Simplify handling of fontproperties=None.
4eda3f2 
... by moving support for it (building a default FontProperties()) to
the generic constructor `FontProperties._from_any`.
@anntzer
Copy link
Contributor Author

anntzer commented May 22, 2020

doc added

@QuLogic QuLogic merged commit 906d8c6 into matplotlib:master May 22, 2020
@QuLogic QuLogic added this to the v3.3.0 milestone May 22, 2020
@anntzer anntzer deleted the fpnone branch May 22, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance topic: text/fonts
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @QuLogic @timhoffm @dstansby