Make error message explicit in legend.py #17488
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make error message explicit
story645
approved these changes
May 22, 2020
QuLogic
previously requested changes
May 22, 2020
Co-authored-by: Elliott Sales de Andrade <[email protected]>
story645
approved these changes
May 25, 2020
|
@ClementWalter Would you be willing to add a test for this? |
|
ok i will try to dit in the next few days |
|
Ping? |
|
This needs a rebase. Prob doesn't desperately need a test, thought it would be nice to up our code coverage. |
|
Hi!
Sorry I was doing completely other things I’ll fix this over the weekend promise
Thanks
Clément Walter
+336.29.44.21.67
… Le 27 janv. 2021 à 22:10, Jody Klymak ***@***.***> a écrit :
This needs a rebase. Prob doesn't desperately need a test, thought it would be nice to up our code coverage.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
timhoffm
reviewed
Jan 28, 2021
Comment on lines
+407
to
+409
| cbook._warn_external('The label {!r} of handle {!r} cannot be ' | ||
| 'a string starting with ' | ||
| '"_"'.format(label, handle)) |
There was a problem hiding this comment.
The merge conflict comes from internal changes cbook._warn_external -> _api.warn_external.
While you're at it, using f-strings makes this more readable.
Suggested change
| cbook._warn_external('The label {!r} of handle {!r} cannot be ' | |
| 'a string starting with ' | |
| '"_"'.format(label, handle)) | |
| _api.warn_external(f'The label {label!r} of handle {handle!r} ' | |
| 'cannot be a string starting with "_"') |
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Feb 9, 2022
Replaces and closes matplotlib#17488. Co-authored-by: Clement Walter <[email protected]>
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Feb 10, 2022
Replaces and closes matplotlib#17488. Co-authored-by: Clement Walter <[email protected]>
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Feb 10, 2022
Replaces and closes matplotlib#17488. Co-authored-by: Clement Walter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Update the error message when label is a string and starts with
_so as to make it clearer to the user.PR Checklist