Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update SVGs that use interpolation='none'. #17493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented May 23, 2020

PR Summary

On versions of Inkscape that interpret the new settings, the tests fail because they are no longer interpolated.

Followup to #17062.

Note, there seem to be other changes in the files, but those are unrelated to the interpolation changing. I'm not sure when they were introduced, but I confirmed that those changes would have happened if the images were replaced before #17062.

PR Checklist

  • Has Pytest style unit tests
  • [N/A] Code is Flake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

On versions of Inkscape that interpret the new settings, the tests fail
because they are no longer interpolated.
@QuLogic QuLogic added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. backend: svg labels May 23, 2020
@QuLogic QuLogic added this to the v3.3.0 milestone May 23, 2020
@tacaswell
Copy link
Member

I tested this commit locally with inkscape 1 and it passes. Going to make an executive decision to merge this with no further review.

@tacaswell tacaswell merged commit 90200c6 into matplotlib:master May 27, 2020
@QuLogic QuLogic deleted the svg-interpolation-images branch May 27, 2020 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: svg Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants