Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Set Win32 AppUserModelId to fix taskbar icons. #17555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2020
Merged

Set Win32 AppUserModelId to fix taskbar icons. #17555

merged 1 commit into from
Jun 23, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jun 2, 2020

PR Summary

Closes #17144. Note that jupyter qtconsole essentially does the same, per https://github.com/jupyter/qtconsole/pull/71/files (except that they use ctypes and don't worry about being embedded in another app).

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v3.4.0 milestone Jun 2, 2020
story645
story645 approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this branch works on my machine.

@anntzer anntzer force-pushed the win32appusermodelid branch from b5255d1 to cac3ccc Compare June 3, 2020 07:36
QuLogic
QuLogic reviewed Jun 20, 2020
View reviewed changes
@anntzer anntzer force-pushed the win32appusermodelid branch from cac3ccc to dbfbb44 Compare June 20, 2020 10:37
@QuLogic
Copy link
Member

QuLogic commented Jun 23, 2020

These are old doc failures, so I'm going to ignore them.

@QuLogic QuLogic merged commit 31aa086 into matplotlib:master Jun 23, 2020
@anntzer anntzer deleted the win32appusermodelid branch June 23, 2020 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic left review comments

@tacaswell tacaswell tacaswell approved these changes

@story645 story645 story645 approved these changes

Assignees
No one assigned
Labels
OS: Microsoft
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

Wrong icon on windows task bar for figure windows
4 participants
@anntzer @QuLogic @tacaswell @story645