Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Convert adjust_bbox to use ExitStack. #17607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2020
Merged

Convert adjust_bbox to use ExitStack. #17607

merged 1 commit into from
Jun 10, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jun 10, 2020

PR Summary

This allows us to use _setattr_cm and not worry about manually restoring things or handling weird attributes ourselves.

The restoration order of Figure properties is a little different, but the tests seem to think this is fine.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic
Convert adjust_bbox to use ExitStack.
602be07 
This allows us to use `_setattr_cm` and not worry about manually
restoring things or handling weird attributes ourselves.
anntzer
anntzer approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neato

@tacaswell tacaswell modified the milestones: v3.3.0, v3.4.0 Jun 10, 2020
@tacaswell tacaswell merged commit 46afd81 into matplotlib:master Jun 10, 2020
@QuLogic QuLogic deleted the tight-layout-exitstack branch June 10, 2020 18:47
@jklymak jklymak mentioned this pull request Jul 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @anntzer @tacaswell