Backport PR #17602: FIX: propagate _is_saving state when changing can… #17609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anging canvases Merge pull request matplotlib#17602 from tacaswell/fix_mixed_canvas_animation_save FIX: propagate _is_saving state when changing canvases Conflicts: lib/matplotlib/backend_bases.py - other nearby changes, only backport the context manager related changes lib/matplotlib/tests/test_figure.py - did not backport the other tests that are currently only on master branch.
QuLogic
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…vases
Merge pull request #17602 from tacaswell/fix_mixed_canvas_animation_save
FIX: propagate _is_saving state when changing canvases
Conflicts:
lib/matplotlib/backend_bases.py
- other nearby changes, only backport the context manager
related changes
lib/matplotlib/tests/test_figure.py
- did not backport the other tests that are currently only on
master branch.