Update hard-coded results in artist tutorial #17761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've added several custom reprs to objects, so these hard-coded results are no longer in sync with what anyone would see.
tacaswell
approved these changes
Jun 26, 2020
QuLogic
commented
Jun 26, 2020
| # | ||
| # In [160]: print(fig.axes) | ||
| # [<matplotlib.axes.Subplot instance at 0xd54b26c>, | ||
| # <matplotlib.axes.Axes instance at 0xd3f0b2c>] | ||
| # [<AxesSubplot:>, <matplotlib.axes._axes.Axes object at 0x7f0768702be0>] |
There was a problem hiding this comment.
Maybe we should add a __repr__ to Axes, too.
| @@ -433,8 +451,8 @@ class in the matplotlib API, and the one you will be working with most | |||
| # None | |||
| # | |||
| # # and the transformation instance is set to the "identity transform" | |||
| # In [265]: print(rect.get_transform()) | |||
| # <Affine object at 0x13695544> | |||
| # In [265]: print(rect.get_data_transform()) | |||
There was a problem hiding this comment.
Note, get_transform is wrong, because it shows the re-scaling of a unit rectangle to the expected size, and not the identity transform that the tutorial is talking about here.
|
Would it be worth changing this to actually run the code rather than being hard-coded? |
|
and anyone can merge on green. |
|
Maybe, right now it's a bit of an odd mix of embedded scripts, and only one or two bits of actually running code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
We've added custom repr for many objects, so these hard-coded results are not what someone would see in the console. Also, capitalize Matplotlib.
PR Checklist