Partially fix rubberbanding in GTK3. #17772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code became wrong because of crossed PRs (resulting in assignment in the readonly `ctx` property). Let's make `ctx` an instance attribute again for now, which at least avoids an exception; however the rubberband is invisible for reasons unclear to me.
|
Upon further investigation we don't need to store the ctx object (I was initially worried this was a gc problem), rather it's something like #17773 (comment) -- so I removed again the private _ctx attribute. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jul 1, 2020
timhoffm
added a commit
that referenced
this pull request
Jul 1, 2020
…772-on-v3.3.x Backport PR #17772 on branch v3.3.x (Partially fix rubberbanding in GTK3.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code became wrong because of crossed PRs (#13144+#17111 resulting in assignment in
the readonly
ctxproperty). Let's makectxan instance attributeagain for now, which at least avoids an exception; however the
rubberband is invisible for reasons unclear to me.
PR Summary
PR Checklist