FIX: don't fail on first show if animation already exhausted #17810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
reviewed
Aug 3, 2020
65d1a19 to
288d438
Compare
timhoffm
approved these changes
Aug 5, 2021
QuLogic
reviewed
Aug 6, 2021
If we need to get the first frame in `_init_draw()` (because the user did not pass an initialization function) fails, warn instead of raising. closes matplotlib#17770
288d438 to
5471db1
Compare
QuLogic
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
If
_init_draw()fails, assume the animation is dead, but do not fail.closes #17770
I am not sure this is actually the best fix. On one hand, this is elides the problem, but does so by ignoring the problem. There is some poor interaction going on here between the ways access the data sources and how we try to "peek" at the first frame if we are not passed an init function.
PR Checklist