pdf: Support setting URLs on Text objects #17832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a good idea to me, and likely to be useful even if it doesn't work for usetex strings. I think including pdf files in pdftex (which I suppose is the main use case for usetex with pdf) breaks links in any case, or at least it did when I last tried which may have been 10+ years ago. |
|
Oh, I think I got that working as well, just didn't update the description. Still need to figure out how to test though. |
|
Tests and documentation added. |
jkseppan
approved these changes
Aug 14, 2020
|
... test failures are real on mac and windows - doesn't like the string parsing... |
|
Ah, because we don't have LaTeX on those systems. |
|
I split that test in two, so it could get the |
This allows annotations which depend on layout of the page to be added.
tacaswell
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This is the minimum needed to get what I wanted
, but it still needs some work to be fully implemented. It currently only works for plain text, and not text that goes throughdraw_tex, as I don't yet know how to get the text bounding box in that path.Also needs tests and documentation.PR Checklist