Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add fullscreen toggle support to WxAgg backend #17843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2020
Merged

Add fullscreen toggle support to WxAgg backend #17843

merged 1 commit into from
Jul 7, 2020

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Jul 5, 2020

PR Summary

This implements the by default empty FigureManagerBase.full_screen_toggle for the WxAgg backend. Qt, Tk and GTK3 already have working implementations for this.

can be tested with either:

import matplotlib
matplotlib.use('wxagg')
import matplotlib.pyplot as plt
plt.plot([1,3,2])
plt.get_current_fig_manager().full_screen_toggle()

or

import matplotlib
matplotlib.use('wxagg')
import matplotlib.pyplot as plt
plt.plot([1,3,2])
plt.show()

and toggle with shortcut f.

@timhoffm timhoffm added this to the v3.4.0 milestone Jul 5, 2020
@timhoffm timhoffm mentioned this pull request Jul 5, 2020
Closed
anntzer
anntzer approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"works for me" :)

@QuLogic
Copy link
Member

QuLogic commented Jul 7, 2020

The default style says to remove menu bar, tool bar, status bar, border and caption. Does that remove our toolbar? And should we turn that off (I don't think other backends do so)?

@timhoffm
Copy link
Member Author

timhoffm commented Jul 7, 2020

Defaults are ok. This is how it looks (blue figure background).

grafik

@QuLogic QuLogic merged commit bdf0177 into matplotlib:master Jul 7, 2020
@timhoffm timhoffm deleted the wxagg-fullscreen branch July 7, 2020 22:16
@QuLogic QuLogic mentioned this pull request Mar 18, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
GUI: wx
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@timhoffm @QuLogic @anntzer