-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Force origin='upper' in pyplot.specgram #17897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
77a2b67
Link to style-file example page in docs
dstansby cc4a4db
Force origin='upper' in specgram function
kate-perkins b5ef28f
DOC: indicate that origin is force set to upper
kate-perkins 3ee2131
Adding test for issue 17878
theodorju 9aab320
DOC: Change rcParam from 'origin' to 'image.origin'
kate-perkins 67df843
TST: try changing origin in specgram call
kate-perkins 48288f8
Document behavior change for specgram
kate-perkins ef4c5dc
Document api behavior change
kate-perkins 45ce308
Reduced line length in test_axes.py
theodorju ae95c37
Merge branch 'fix-for-issue-17878' of https://github.com/kate-perkins…
theodorju 8d24ff7
Raise exception if origin kwarg passed to specgram
kate-perkins 9cf10dd
TST: passing origin kwarg to specgram should fail
kate-perkins 8856c7f
Merge by keeping most recent
kate-perkins 054ed06
Shorten long line
kate-perkins 326ce3e
Fix documentation build error
kate-perkins d5959b5
DOC: Remove note that origin='upper' in specgram
kate-perkins c9e1154
Shorten title and spell out keyword argument
kate-perkins d0968be
TST: change from pytest xfail to pytest raises
kate-perkins e4249e0
DOC: Add blank line after kwargs parameter
kate-perkins 5633a45
Remove whitespace on blank line
kate-perkins 2310ff5
Shorten long line
kate-perkins f8afa14
Fix documentation build error
kate-perkins 007eaae
DOC: Remove note that origin='upper' in specgram
kate-perkins 3f06646
Shorten title and spell out keyword argument
kate-perkins d79202f
TST: change from pytest xfail to pytest raises
kate-perkins 3e6aa01
DOC: Add blank line after kwargs parameter
kate-perkins 3aed2cf
Remove whitespace on blank line
kate-perkins f958e88
Wrap lines
kate-perkins 0d53e81
Merge by keeping most recent
kate-perkins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
pyplot.specgram always uses origin='upper' | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
Previously if ``image.origin`` was set to something other than 'upper' or if the | ||
``origin`` keyword argument was passed with a value other than 'upper', the spectrogram | ||
itself would flip, but the axes would remain oriented for an origin value of 'upper', so | ||
that the resulting plot was incorrectly labelled. | ||
|
||
Now, the ``origin`` keyword argument is not supported and the ``image.origin`` rcParam is | ||
ignored. The function matplotlib.pyplot.specgram is forced to use ``origin='upper'``, so | ||
that the axes are correct for the plotted spectrogram. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.