Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Honor 'Date': None in metadata #17969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2020
Merged

Honor 'Date': None in metadata #17969

merged 2 commits into from
Jul 22, 2020

Conversation

yuyichao
Copy link
Contributor

@yuyichao yuyichao commented Jul 19, 2020 •
edited
Loading

Allow removing the 'Date' metadata from output.

Fix #17968

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

dstansby
dstansby reviewed Jul 19, 2020
View reviewed changes
@yuyichao
Copy link
Contributor Author

yuyichao commented Jul 19, 2020 •
edited
Loading

I added a few more tests. I also included a commit to remove the metadata tag altogether if it was going to be empty since,

  1. I would like to do it anyway (in a different pr) to make the svg files closer to the one from previous versions
  2. such change will affect the test result here so that's not really a very indepndent PR
  3. having that change makes one of the test somewhat easier
  4. the test for that change relies on this since there's no way to generate an empty metadata currently...

jklymak
jklymak reviewed Jul 19, 2020
View reviewed changes
@yuyichao yuyichao mentioned this pull request Jul 19, 2020
Closed
tacaswell
tacaswell reviewed Jul 19, 2020
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested what I think is a clearer way way of spelling the checking (so that we only have to reach into the meta-data once), but I am not going to block over that.

This is a 👍 from a point of view of counting positive reviews, but like my complaint to be considered.

@tacaswell tacaswell added this to the v3.3.1 milestone Jul 19, 2020
QuLogic
QuLogic reviewed Jul 20, 2020
View reviewed changes
@tacaswell tacaswell merged commit 6958f88 into matplotlib:master Jul 22, 2020
@tacaswell
Copy link
Member

Thanks @yuyichao ! Congratulations on your first Matplotlib PR 🎉 Hopefully we will hear from you again.

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jul 22, 2020
@tacaswell @meeseeksmachine
Backport PR matplotlib#17969: Honor 'Date': None in metadata
5010de1
@meeseeksmachine meeseeksmachine mentioned this pull request Jul 22, 2020
Merged
QuLogic added a commit that referenced this pull request Jul 22, 2020
@QuLogic
Merge pull request #18008 from meeseeksmachine/auto-backport-of-pr-17…
5f24501 
…969-on-v3.3.x

Backport PR #17969 on branch v3.3.x (Honor `'Date': None` in metadata)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell left review comments

@jklymak jklymak jklymak left review comments

@dstansby dstansby dstansby left review comments

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
backend: pdf backend: svg
Projects
None yet
Milestone
v3.3.1
Development

Successfully merging this pull request may close these issues.

Setting Date metadata to None does not remove the date metadata from the SVG file
5 participants
@yuyichao @tacaswell @QuLogic @jklymak @dstansby