gtk: Fix draw on unmapped windows.
#17981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most other backends do not skip drawing on unmapped windows; this skip causes explicit draws to do nothing and breaks things that expect it to work. For example, the `TextBox` example broke since the widget was changed to set text before showing the window. This required drawing to work in order to measure text size and place the caret.
tacaswell
approved these changes
Jul 21, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jul 22, 2020
|
Merged on a single review and trusting that @QuLogic tested this locally. |
timhoffm
added a commit
that referenced
this pull request
Jul 22, 2020
…981-on-v3.3.x Backport PR #17981 on branch v3.3.x (gtk: Fix `draw` on unmapped windows.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Most other backends do not skip drawing on unmapped windows; this skip causes explicit draws to do nothing and breaks things that expect it to work.
For example, the
TextBoxexample broke since the widget was changed to set text before showing the window (#17117). This required drawing to work in order to measure text size and place the caret.PR Checklist
Maybe?