Shorten tight_bbox. #17992
Merged
Shorten tight_bbox. #17992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
reviewed
Jul 21, 2020
jklymak
approved these changes
Jul 21, 2020
QuLogic
approved these changes
Jul 21, 2020
|
Is the docstring okay instead of a comment? Not sure what part you're referring to. |
|
I guess @jklymak is hoping for more comments, but let's leave that for another time :) |
|
I find _pos = ax.get_position(original=False).frozen()
ax.set_axes_locator(lambda a, r, _pos=_pos: _pos)to be pretty obscure and self-referential... |
|
It's basically the same as before the PR? |
jklymak
reviewed
Jul 21, 2020
It's more readable to directly define the relevant callbacks (axes_locator, apply_aspect) as one-line lambdas at the point of use, instead of having to define them much earlier. Pickling is not an issue as these lambdas are only set temporarily while computing the figure tightbbox for saving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's more readable to directly define the relevant callbacks
(axes_locator, apply_aspect) as one-line lambdas at the point of use,
instead of having to define them much earlier. Pickling is not an issue
as these lambdas are only set temporarily while computing the figure
tightbbox for saving.
PR Summary
PR Checklist