Typos and docs for mathtext fonts. #18004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Jul 21, 2020
QuLogic
reviewed
Jul 21, 2020
QuLogic
approved these changes
Jul 22, 2020
timhoffm
reviewed
Jul 22, 2020
|
handled. |
f5d2a77 to
ba39454
Compare
... in particular regarding the undocumented *font_class* parameter. Also rename an unrelated variable also named `font_class` to avoid confusion. Also remove redundant entry for mathfrak+mathit in `stix_virtual_fonts` -- there's actually no frak+it font, the table just duplicates frak+rm, but we already fallback to rm by default anyways.
As can be checked with
```
rcParams["ps.useafm"] = True
figtext(.5, .5, "$\\Lambda\varphi$")
savefig("/tmp/test.ps")
```
and inspecting the resulting file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
First commit:
Improve docs of mathtext internals, in particular regarding the
undocumented font_class parameter.
Also rename an unrelated variable also named
font_classto avoidconfusion.
Also remove redundant entry for mathfrak+mathit in
stix_virtual_fonts-- there's actually no frak+it font, the table just duplicates frak+rm,
but we already fallback to rm by default anyways.
Second commit:
Fix typos in mathtext_data, as can be checked with
and inspecting the resulting file.
PR Checklist