Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix ToolManager inconsistencies with regular toolbar #18006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jul 21, 2020

PR Summary

This fixes some inconsistencies between the MEP 22 tool manager and the regular toolbar.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

QuLogic added 2 commits July 21, 2020 17:25
They are almost the same code, but fell a little out of sync, with the
toolbar using two lines in some cases, while ToolManager used the old
single-line message.
@QuLogic QuLogic added the MEP: MEP22 tool manager label Jul 21, 2020
@QuLogic QuLogic added this to the v3.4.0 milestone Jul 21, 2020
@jkseppan jkseppan merged commit b38a870 into matplotlib:master Aug 2, 2020
@QuLogic QuLogic deleted the mep22-fixes branch August 2, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MEP: MEP22 tool manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants