FIX: Be sure matplotlib.backends is imported before we use it #18026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user specifies the backend via `'module://XZY'` there in no guarantee that they have imported `matplotilb.backends` (which is an empty `__init__.py`) as part of their module which results in an AttributeError when we monkeypatch the backend name into it. closes matplotlib#18022
jklymak
approved these changes
Jul 22, 2020
QuLogic
approved these changes
Jul 23, 2020
timhoffm
approved these changes
Jul 23, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jul 23, 2020
…orted before we use it
timhoffm
added a commit
that referenced
this pull request
Jul 23, 2020
…026-on-v3.3.x Backport PR #18026 on branch v3.3.x (FIX: Be sure matplotlib.backends is imported before we use it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
If the user specifies the backend via
'module://XZY'there in noguarantee that they have imported
matplotilb.backends(which isan empty
__init__.py) as part of their module which results in anAttributeError when we monkeypatch the backend name into it.
closes #18022
PR Checklist