Fix PolyCollection.set_verts optimization. #18030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should only trigger on 3D arrays (i.e., (Npolys, M, 2)-shaped arrays), and not, e.g., object arrays of 2D array-likes. Also, fix a small doc typo. Fixes matplotlib#18017.
timhoffm
approved these changes
Jul 23, 2020
jklymak
approved these changes
Jul 23, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jul 23, 2020
tacaswell
added a commit
that referenced
this pull request
Jul 23, 2020
…030-on-v3.3.x Backport PR #18030 on branch v3.3.x (Fix PolyCollection.set_verts optimization.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
It should only trigger on 3D arrays (i.e., (Npolys, M, 2)-shaped arrays), and not, e.g., object arrays of 2D array-likes.
Also, fix a small doc typo.
Fixes #18017.
PR Checklist