Correctly handle 'none' facecolors in do_3d_projection #18060
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Jul 25, 2020
|
We might not have to backport this given that #17861 reverted the changes on v3.3.x? |
|
#17850 is also relevant here? |
|
|
#17850 was merged, so it looks like this needs to be changed to only include the test. |
|
Looks like #18020 is closed, so I'm going to close this too. |
|
Did you not want to keep the test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18020.
Changes made in #17543 meant that
_facecolor3dcan now be an empty array, therefore make suredo_3d_projectiononly handles the case where the facecolor is set.