Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix linting on v3.3.x #18102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 30, 2020
Merged

Fix linting on v3.3.x #18102

merged 3 commits into from
Jul 30, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jul 28, 2020

PR Summary

Backport of #18091, plus correction of flake8 error (see commits).

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [n/a] New features are documented, with examples if plot related
  • [n/a] Documentation is sphinx and numpydoc compliant
  • [n/a] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [n/a] Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

QuLogic added 2 commits July 28, 2020 17:46
@QuLogic
ci: Add tee to debug reviewdog.
575c37b
@QuLogic
ci: Disable filtering of lint errors.
5cfec07 
For certain reporters, it's necessary to do this filtering because
GitHub does not allow posting to unrelated files. The github-check
reporter _should_ allow it though, and we want to catch things like
unused imports that may not be in the diff.
@QuLogic QuLogic added this to the v3.3.1 milestone Jul 28, 2020
@QuLogic
Silence an unused import warning.
89d05ca 
Since this is on a bugfix branch, don't remove the import in case it's
in use.

And fix a missing empty line.
timhoffm
timhoffm reviewed Jul 28, 2020
View reviewed changes
@timhoffm
Copy link
Member

CI failure Will be fixed by #18104.

jkseppan
jkseppan approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@jkseppan jkseppan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me but there are some Travis failures. I restarted the failing jobs, but I don't know if Travis will merge the current v3.3.x before running the tests. If not, perhaps this branch could be rebased on top of v3.3.x.

@jkseppan
Copy link
Member

The restarted Travis runs passed, so I think this is safe to merge

@jkseppan jkseppan merged commit 8187369 into matplotlib:v3.3.x Jul 30, 2020
@QuLogic QuLogic deleted the flake8-v33x branch July 30, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift left review comments

@jkseppan jkseppan jkseppan approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@QuLogic @timhoffm @jkseppan @dopplershift