-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Sort 3d sizes along with other properties #18136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This seems to be the right solution, but this is going to need a test. You can use the demo code in the original issue as the basis for the test. |
Targeting for 3.3.1 as release critical, because it's a regression in 3.3.0 introduced via #17378. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe plotting 100 points was overkill thinking about it. Let me know if you want me to reduce the number of points.
That does not affect the drawing time significantly, so IMHO it's ok.
This looks pretty good. Quick question for the peanut gallery. Technically speaking, a |
Is an image test really required here? Can you not pull the sizes from the produced collection, or is this re-ordering draw-dependent? If that's not possible, then I think we can still use a figure comparison test instead. Just compare with a plot using individual scatter calls. |
@QuLogic The reordering is draw dependant so I couldn't get a standard test to work using |
@tomneep Can you squash this to one commit (or we can squash-merge it)? As it is the image will still be in the history (and we are trying to keep the repo from getting even bigger than it already is). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modulo rebase, or we can squash.
@tacaswell Makes sense. I've rebased and squashed into a single commit. |
Thanks @tomneep! |
…136-on-v3.3.x Backport PR #18136 on branch v3.3.x (Sort 3d sizes along with other properties)
PR Summary
Fixes #18135. The sizes of the points need to be updated when reordering along with the other properties.
PR Checklist