Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix nbagg in Chrome 84 #18142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 2, 2020
Merged

Fix nbagg in Chrome 84 #18142

merged 3 commits into from
Aug 2, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Aug 1, 2020 •
edited
Loading

PR Summary

We check attributes for Firefox, and old Chrome. Chrome 84 implements a new version of the ResizeObserver spec, which uses the same attribute names as Firefox, but a different type. Naturally, JS doesn't complain and just returns undefined...

Also, fix the menu showing up on right-click.

Fixes #18132.

PR Checklist

  • [n/a] Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [n/a] New features are documented, with examples if plot related
  • [n/a] Documentation is sphinx and numpydoc compliant
  • [n/a] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [n/a] Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

QuLogic added 3 commits July 31, 2020 20:42
@QuLogic
Fix nbAgg sizing on Chrome 84.
9ad99c4 
The ResizeObserver spec changed, though Firefox still does the old way.
Previous Chrome implemented an even older version, and 84 implements the
latest version, but not this in-between one we're using.
@QuLogic
nbagg: Use device sized content size to resize canvas.
d50fded 
This is only implemented on Chrome, but prevents some blurriness.
@QuLogic
nbAgg: Fix disabling the context menu in the canvas.
d965261
@QuLogic QuLogic added this to the v3.3.1 milestone Aug 1, 2020
@QuLogic QuLogic added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Aug 1, 2020
jkseppan
jkseppan approved these changes Aug 2, 2020
View reviewed changes
Copy link
Member

@jkseppan jkseppan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I don't know the details of all the specs. I trust that you tested this with the browsers mentioned in comments.

@jklymak jklymak merged commit df50f12 into matplotlib:master Aug 2, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Aug 2, 2020
@jklymak @meeseeksmachine
Backport PR matplotlib#18142: Fix nbagg in Chrome 84
77062a7
@meeseeksmachine meeseeksmachine mentioned this pull request Aug 2, 2020
Merged
@QuLogic QuLogic deleted the fix-nbagg-chrome84 branch August 2, 2020 19:35
dopplershift added a commit that referenced this pull request Aug 2, 2020
@dopplershift
Merge pull request #18153 from meeseeksmachine/auto-backport-of-pr-18…
6a6c6d1 
…142-on-v3.3.x

Backport PR #18142 on branch v3.3.x (Fix nbagg in Chrome 84)
@QuLogic QuLogic mentioned this pull request Aug 4, 2020
Merged
2 tasks
@jklymak jklymak mentioned this pull request Aug 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkseppan jkseppan jkseppan approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
GUI: nbagg GUI: webagg Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.3.1
Development

Successfully merging this pull request may close these issues.

A simple 3D scatter plot with %matplotlib notebook is not working
3 participants
@QuLogic @jkseppan @jklymak