FIX: check if axes is off page before repositioning title #18288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yeeesh, why am I getting flake8 complaints for a file I didn't edit? |
|
It looks like something changed in the flake8 incantation? |
jklymak
commented
Aug 18, 2020
| @@ -1,6 +1,5 @@ | |||
| from io import BytesIO | |||
| import pickle | |||
| import platform | |||
There was a problem hiding this comment.
This is just to make flake8 happy - not part of this PR, but flake8 now seems to check all files, not just modified.
dopplershift
approved these changes
Aug 18, 2020
9e8acd6 to
a9ac3d9
Compare
timhoffm
approved these changes
Aug 19, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 19, 2020
…epositioning title
timhoffm
added a commit
that referenced
this pull request
Aug 19, 2020
…288-on-v3.3.x Backport PR #18288 on branch v3.3.x (FIX: check if axes is off page before repositioning title)
SidharthBansal
pushed a commit
to SidharthBansal/matplotlib
that referenced
this pull request
Aug 20, 2020
…page FIX: check if axes is off page before repositioning title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #18283
We now automatically place the title to avoid decorators on the x axis (particuarly if the axis is at the top). However if the whole axes is cropped due to a
bbox_inches=extentcall, then the title still gets placed at a defaulty=0. This change checks if thetopis in the figure, and if not, then it doesn't auto position the title.PR Checklist