Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix scatter3d color/linewidth re-projection #18293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 29, 2020
Merged

Fix scatter3d color/linewidth re-projection #18293

merged 5 commits into from
Aug 29, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Aug 19, 2020

PR Summary

Technically, it's tested, though the test wasn't strictly designed to do so (#18156). Not sure if I should write a different test.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [n/a] New features are documented, with examples if plot related
  • [n/a] Documentation is sphinx and numpydoc compliant
  • [n/a] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [n/a] Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

QuLogic added 2 commits August 18, 2020 21:52
@QuLogic
Remove redundant alpha in Path3DCollection.
18271f8
@QuLogic
Correctly re-order scatter3d face/edgecolors.
5bd536b 
They should be re-ordered regardless of depth shading, but rather
dependent on whether there's more than one colour.

Fixes matplotlib#18287.
@QuLogic QuLogic added this to the v3.3.2 milestone Aug 19, 2020
@timhoffm
Copy link
Member

Technically, it's tested, though the test wasn't strictly designed to do so (#18156). Not sure if I should write a different test.

How can this have been tested? The behavior was broken and is now fixed, but you did not have to change anything in the tests.

@dopplershift
Copy link
Contributor

That lines up with where codecov says exactly 0% of the lines of code touched in this PR have been executed by the test suite.

@QuLogic
Copy link
Member Author

QuLogic commented Aug 19, 2020

Sorry, I guess what is tested is the opposite case. I can write up something that should cover everything.

@QuLogic QuLogic changed the title Fix scatter3d color re-projection Fix scatter3d color/linewidth re-projection Aug 19, 2020
@QuLogic
Copy link
Member Author

QuLogic commented Aug 19, 2020

I pushed a more extensive test, and also found that linewidth was not correctly propagated, so fixed that as well.

There's still a bug in #18287 in that initial draw is not correct, but any change in the view angle re-calculates stuff so it appears correctly. I think there's some stale trigger missing in view_init, but need to investigate that for a bit.

@QuLogic
Copy link
Member Author

QuLogic commented Aug 20, 2020

I'm very confused about this initial draw thing. To be clear, this PR does fix the sorting, which you can confirm by running #18287, and then rotating the view of the first figure so that the markers's depths are reversed.

However, on the second figure, the face colours of the scatter markers are not sorted, though the edge colours are. Inserting a draw (of any kind, lazy or forced) just before plt.show() magically fixes it. As far as I can tell, Path3DCollection.do_3d_projection sorts everything exactly the same way on both draws, but somehow it doesn't reflect that in the result.

@tacaswell
Copy link
Member

I'm happy to merge this as-is without tracking down why the initial draw is wrong (which is not to say that isn't a bug that needs to be fixed).

dopplershift
dopplershift approved these changes Aug 29, 2020
View reviewed changes
Copy link
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, let's deal with any initial draw issues in a separate PR.

@dopplershift dopplershift merged commit 52f7f42 into matplotlib:master Aug 29, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Aug 29, 2020
@dopplershift @meeseeksmachine
Backport PR matplotlib#18293: Fix scatter3d color/linewidth re-projec…
80fbbb1 
…tion
@meeseeksmachine meeseeksmachine mentioned this pull request Aug 29, 2020
Merged
timhoffm added a commit that referenced this pull request Aug 29, 2020
@timhoffm
Merge pull request #18375 from meeseeksmachine/auto-backport-of-pr-18…
a8709b5 
…293-on-v3.3.x

Backport PR #18293 on branch v3.3.x (Fix scatter3d color/linewidth re-projection)
@QuLogic QuLogic deleted the scatter3d-color branch August 30, 2020 01:07
@scottshambaugh scottshambaugh mentioned this pull request Dec 21, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
topic: mplot3d
Projects
None yet
Milestone
v3.3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@QuLogic @timhoffm @dopplershift @tacaswell