Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Synchronize units change in Axis.set_units for shared axis #18308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 24, 2020
Merged

Synchronize units change in Axis.set_units for shared axis #18308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f77c0a5
Add set_xunits and set_yunits
l-johnston Aug 20, 2020
6d54d3a
Synchronize units change in Axis.set_units for shared axis
l-johnston Aug 21, 2020
fb76ed7
Add test for datetime and categorical
l-johnston Aug 21, 2020
332d31d
Separate shared_axis tests
l-johnston Aug 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions lib/matplotlib/axis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1530,14 +1530,31 @@ def set_units(self, u):
Parameters
----------
u : units tag

Notes
-----
The units of any shared axis will also be updated.
"""
if u == self.units:
return
self.units = u
self._update_axisinfo()
self.callbacks.process('units')
self.callbacks.process('units finalize')
self.stale = True
if self is self.axes.xaxis:
shared = [
ax.xaxis
for ax in self.axes.get_shared_x_axes().get_siblings(self.axes)
]
elif self is self.axes.yaxis:
shared = [
ax.yaxis
for ax in self.axes.get_shared_y_axes().get_siblings(self.axes)
]
else:
shared = [self]
for axis in shared:
axis.units = u
axis._update_axisinfo()
axis.callbacks.process('units')
axis.callbacks.process('units finalize')
axis.stale = True

def get_units(self):
"""Return the units for axis."""
Expand Down
53 changes: 46 additions & 7 deletions lib/matplotlib/tests/test_units.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
from datetime import datetime
from datetime import datetime, timezone, timedelta
import platform
from unittest.mock import MagicMock

import matplotlib.pyplot as plt
from matplotlib.testing.decorators import check_figures_equal, image_comparison
import matplotlib.units as munits
from matplotlib.category import UnitData
import numpy as np
import pytest

Expand Down Expand Up @@ -127,12 +128,12 @@ def test_jpl_bar_units():
units.register()

day = units.Duration("ET", 24.0 * 60.0 * 60.0)
x = [0*units.km, 1*units.km, 2*units.km]
w = [1*day, 2*day, 3*day]
x = [0 * units.km, 1 * units.km, 2 * units.km]
w = [1 * day, 2 * day, 3 * day]
b = units.Epoch("ET", dt=datetime(2009, 4, 25))
fig, ax = plt.subplots()
ax.bar(x, w, bottom=b)
ax.set_ylim([b-1*day, b+w[-1]+(1.001)*day])
ax.set_ylim([b - 1 * day, b + w[-1] + (1.001) * day])


@image_comparison(['jpl_barh_units.png'],
Expand All @@ -142,13 +143,13 @@ def test_jpl_barh_units():
units.register()

day = units.Duration("ET", 24.0 * 60.0 * 60.0)
x = [0*units.km, 1*units.km, 2*units.km]
w = [1*day, 2*day, 3*day]
x = [0 * units.km, 1 * units.km, 2 * units.km]
w = [1 * day, 2 * day, 3 * day]
b = units.Epoch("ET", dt=datetime(2009, 4, 25))

fig, ax = plt.subplots()
ax.barh(x, w, left=b)
ax.set_xlim([b-1*day, b+w[-1]+(1.001)*day])
ax.set_xlim([b - 1 * day, b + w[-1] + (1.001) * day])


def test_empty_arrays():
Expand All @@ -172,3 +173,41 @@ class subdate(datetime):

fig_test.subplots().plot(subdate(2000, 1, 1), 0, "o")
fig_ref.subplots().plot(datetime(2000, 1, 1), 0, "o")


def test_shared_axis_quantity(quantity_converter):
munits.registry[Quantity] = quantity_converter
x = Quantity(np.linspace(0, 1, 10), "hours")
y1 = Quantity(np.linspace(1, 2, 10), "feet")
y2 = Quantity(np.linspace(3, 4, 10), "feet")
fig, (ax1, ax2) = plt.subplots(2, 1, sharex='all', sharey='all')
ax1.plot(x, y1)
ax2.plot(x, y2)
assert ax1.xaxis.get_units() == ax2.xaxis.get_units() == "hours"
assert ax2.yaxis.get_units() == ax2.yaxis.get_units() == "feet"
ax1.xaxis.set_units("seconds")
ax2.yaxis.set_units("inches")
assert ax1.xaxis.get_units() == ax2.xaxis.get_units() == "seconds"
assert ax1.yaxis.get_units() == ax2.yaxis.get_units() == "inches"


def test_shared_axis_datetime():
# datetime uses dates.DateConverter
y1 = [datetime(2020, i, 1, tzinfo=timezone.utc) for i in range(1, 13)]
y2 = [datetime(2021, i, 1, tzinfo=timezone.utc) for i in range(1, 13)]
fig, (ax1, ax2) = plt.subplots(1, 2, sharey=True)
ax1.plot(y1)
ax2.plot(y2)
ax1.yaxis.set_units(timezone(timedelta(hours=5)))
assert ax2.yaxis.units == timezone(timedelta(hours=5))


def test_shared_axis_categorical():
# str uses category.StrCategoryConverter
d1 = {"a": 1, "b": 2}
d2 = {"a": 3, "b": 4}
fig, (ax1, ax2) = plt.subplots(1, 2, sharex=True, sharey=True)
ax1.plot(d1.keys(), d1.values())
ax2.plot(d2.keys(), d2.values())
ax1.xaxis.set_units(UnitData(["c", "d"]))
assert "c" in ax2.xaxis.get_units()._mapping.keys()