-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
add mpl_interactions to 3rd party packages #18325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ca90e79
to
2d1f7ca
Compare
woops - I'd |
270k ist still a call for the image. The page contains tenths of libraries and we don't want the user have to download megabytes of image data. |
Just tried remaking it and got it down to 152.4 kB I also ran the numpngw animation through tinypng which removed 330 kB so the page size would be net |
compressed using tinypng.com and tinyjpg.com
2d1f7ca
to
d1bdfe4
Compare
I went ahead and compressed them all, used a second commit in case that was not the right call. I also compressed the one jpg using tinyjpg.com. Finally, I inspected each image using the visual comparison in GitHub desktop and was unable to pick out any visual differences. |
Looks good to me 👍 Thank you for taking the initiative to clean up the whole lot @ianhi ! The only argument I could see against compressing all of them is that it will bloat the repo, but compared to the test images this is noise. |
…325-on-v3.3.1-doc Backport PR #18325 on branch v3.3.1-doc (add mpl_interactions to 3rd party packages)
PR Summary
Adds https://mpl-interactions.readthedocs.io/en/latest/ (github here) to the list of 3rd party packages. The main utility provided by the library is controlling the parameters to a function you plot using sliders or other widgets. At first, this was ipympl specific, but after some growing pains, it now works in any backend by using matplotlib sliders if not in a notebook. This made me feel ok renaming it from
ipympl-interactions
tompl_interactions
and including some things that independent of backend. For example, it provides the zoom_factory discussed in #18159 as well as some more idiosyncratic stuff such as the scalar figsize argument discussed in: #18244The best single set of examples lives in https://mpl-interactions.readthedocs.io/en/latest/Gallery.html
Also for posterity: mega credit is due to @samanthahamilton who was super helpful in creating and improving the docs!
PR Checklist
I tried to build the docs to check for sphinx errors but I can't even get master to build :( so here's hoping
For the animation, I followed numpngw and made an apng. For full transparency here's the life course of that animation: