Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add missing check for None in Qt toolmanager. #18328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2020
Merged

Add missing check for None in Qt toolmanager. #18328

merged 1 commit into from
Aug 23, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Aug 23, 2020

(The fix is already there in all other backends.)
closes #18327; adding tests is tracked as #17999.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@anntzer
Add missing check for None in Qt toolmanager.
b3dc410 
(The fix is already there in all other backends.)
@anntzer anntzer added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. MEP: MEP22 tool manager labels Aug 23, 2020
@anntzer anntzer added this to the v3.3.2 milestone Aug 23, 2020
@dstansby dstansby merged commit 9cd1152 into matplotlib:master Aug 23, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Aug 23, 2020
@dstansby @meeseeksmachine
Backport PR matplotlib#18328: Add missing check for None in Qt toolma…
a93b9fd 
…nager.
@meeseeksmachine meeseeksmachine mentioned this pull request Aug 23, 2020
Merged
@anntzer anntzer deleted the qtm branch August 23, 2020 15:57
dopplershift added a commit that referenced this pull request Aug 23, 2020
@dopplershift
Merge pull request #18333 from meeseeksmachine/auto-backport-of-pr-18…
1d75e5b 
…328-on-v3.3.x

Backport PR #18328 on branch v3.3.x (Add missing check for None in Qt toolmanager.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
MEP: MEP22 tool manager Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.3.2
Development

Successfully merging this pull request may close these issues.

Tool Manager: adding buttons to toolbar fails with matplotlib version 3.3.1 using Qt backend
3 participants
@anntzer @timhoffm @dstansby