Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support horizontalalignment in TextArea/AnchoredText. #18367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Aug 28, 2020

PR Summary

This turned out to be pretty straightforward, and seems to have not broken anything. We could also do the same thing for vertical alignment, but since multi-line text doesn't flow that way (that I know of), I'm not sure it would have any effect.

Fixes #18363.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Copy link
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just the minor typo.

@dopplershift dopplershift added this to the v3.4.0 milestone Aug 28, 2020
@QuLogic QuLogic force-pushed the anchoredtext-align branch from 36b7ee7 to 50ec1c6 Compare August 28, 2020 05:31
@tacaswell tacaswell merged commit e92ff3b into matplotlib:master Aug 28, 2020
@QuLogic QuLogic deleted the anchoredtext-align branch August 28, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ha="right" breaks AnchoredText placement.
4 participants