FIX: make _reshape_2D accept pandas df with string indices #18374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7f98aae to
27a81eb
Compare
|
ping @mwaskom for your opinion.... Thanks! |
|
Seems reasonable for handling pandas objects, but if someone passes in a dictionary (or anything else with a I guess matplotlib doesn't in general support dict inputs so that's maybe not a risk, although boxplots are an obvious place to do so (each entry in the dict becomes a box over its values vector at the location of its key). |
|
Ok it's pretty easy to also check if values returns an array. I guess I'm just used to values from xarray. |
27a81eb to
cf9bb88
Compare
phobson
approved these changes
Aug 29, 2020
timhoffm
approved these changes
Aug 29, 2020
|
Anybody can merge after CI psss. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 30, 2020
…with string indices
dopplershift
added a commit
that referenced
this pull request
Aug 30, 2020
…374-on-v3.3.x Backport PR #18374 on branch v3.3.x (FIX: make _reshape_2D accept pandas df with string indices)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18371
In #17289 we changed
_reshape_2D(used byviolinplotandboxplot). It used to basically just callnp.asanyarray(X)which works fine with pandas. However, there is a ragged array deprecation, so #17289 now iterates over the columns usingfor x in Xto get each column of the matrix individually.That is incompatible with Pandas data frame like
df = pd.DataFrame(np.random.randn(100, 3), columns=["a", "b", "c"]), which return the error in #18371, which is a regression.Here we try to extract the matrix from X using
to_numpy()orvaluesbefore doing the rest of the manipulations.Note this still doesn't do the "right thing" for the column names, at least using box plot, but this fixes the regression. If the folks who use boxplot or violinplot want to do something fancier with the column names they can try to make that work in some reasonable way, but I think such fancy pandas handling really belongs in pandas, or perhaps the structured data refactor.