Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC: fix date example #18429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2020
Merged

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Sep 7, 2020

PR Summary

The description of the example at https://matplotlib.org/devdocs/gallery/text_labels_and_annotations/date.html#sphx-glr-gallery-text-labels-and-annotations-date-py wasn't up to date wrt to the epoch, and could use some links to the locator and formatter.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@jklymak jklymak added this to the v3.4.0 milestone Sep 7, 2020
@jklymak jklymak force-pushed the doc-fix-date-example branch from 5bdb6d6 to 9940b1d Compare September 7, 2020 16:36
@jklymak jklymak force-pushed the doc-fix-date-example branch from 9940b1d to d926cb0 Compare September 7, 2020 16:38
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took the liberty of pushing a fix to the cross references, and suggested a small change to the text (but not going to block over it).

If CI is green anyone can merge.

@jklymak jklymak merged commit 855e3bb into matplotlib:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants