Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Move Axes __repr__ from Subplot to AxesBase. #18452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2020
Merged

Move Axes __repr__ from Subplot to AxesBase. #18452

merged 1 commit into from
Sep 11, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 10, 2020

The implementation is not particularly specific to gridspec-managed
axes; it can reasonably also be used for arbitrarily-positioned axes.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer
Move Axes __repr__ from Subplot to AxesBase.
41d0765 
The implementation is not particularly specific to gridspec-managed
axes; it can reasonably also be used for arbitrarily-positioned axes.
@anntzer anntzer added this to the v3.4.0 milestone Sep 10, 2020
tacaswell
tacaswell approved these changes Sep 11, 2020
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The azure win py38 error looks like issues with nbconvert.

@timhoffm timhoffm merged commit 296de82 into matplotlib:master Sep 11, 2020
@anntzer anntzer deleted the axesrepr branch September 11, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @tacaswell @jklymak @timhoffm