Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Prose copy edits #18474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 18, 2020
Merged

Prose copy edits #18474

merged 3 commits into from
Sep 18, 2020

Conversation

jeromefv
Copy link
Contributor

@jeromefv jeromefv commented Sep 14, 2020 •
edited
Loading

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

jklymak
jklymak reviewed Sep 14, 2020
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree w/ all of these. However, please remove the rst file from your commit (do git rm doc/tutorials/introductory/usage.rst).

brunobeltran
brunobeltran previously requested changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@brunobeltran brunobeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor tweaks, plus the `->* fix from Jody, then this should just go in.

@jeromefv
Copy link
Contributor Author

Thank you @jklymak and @brunobeltran for the suggestions! I've completed the requests and have moved forward with the process.

@jklymak jklymak merged commit 50ee877 into matplotlib:master Sep 18, 2020
@QuLogic QuLogic added this to the v3.4.0 milestone Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic left review comments

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

@dstansby dstansby dstansby approved these changes

@brunobeltran brunobeltran Awaiting requested review from brunobeltran

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jeromefv @QuLogic @brunobeltran @jklymak @timhoffm @dstansby