BF: ensure exception caught if no kpeswitch #18475
Conversation
|
P.S. Not sure how to test this, since it requires no LaTeX be installed, and our tests require LaTeX be installed. I could shim Alternatively, we currently skip our test of |
There was a problem hiding this comment.
In the other places where we use this we have already checked that the expected executable exists.
Is worth adding a note to the docstring of _check_and_log_subprocess that you are still responsible for the file not existing?
I would not worry about adding a test for this, the trade off of effort required to make it work vs the scale of the bug it is protecting us from coming back is not in it's favor.
|
the OSX failure is pip not seeing pyqt5 or new versions of pyside2 to install, it is not worth holding this PR over it. |
…475-on-v3.3.x Backport PR #18475 on branch v3.3.x (BF: ensure exception caught if no kpeswitch)
PR Summary
Currently, if there is no LaTeX install on a system, we document that we return the empty string for any LaTeX strings (see e.g.
dviread.find_tex_file).However, on my system, I instead get the cryptic (from an end-user's perspective) FileNotFoundError for
kpeswitch.Easy enough to fix by just catching this error, we're already catching
RuntimeError.PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).