Thanks to visit codestin.com
Credit goes to github.com

Skip to content

TST: Add test for _repr_html_ #18501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 22, 2020
Merged

TST: Add test for _repr_html_ #18501

merged 4 commits into from
Sep 22, 2020

Conversation

larsoner
Copy link
Contributor

PR Summary

I got some TemporaryDirectory ResourceWarning's in a sphinx-gallery-based doc builds with matplotlib animations, so I started trying to replicate them with some minimal code. I couldn't, but it looked like there weren't any explicit _repr_html_ tests in the test_animation.py code, so I figured I'd open a PR to add some basic ones (these were my minimal examples that showed no problems at the mpl end).

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've got a few flake8 issues as well.

@dstansby dstansby added this to the v3.4.0 milestone Sep 17, 2020
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, but can you move the anim fixture earlier. I know it's not strictly required to define it before use, but it's nicer to keep fixtures together at the beginning (unless the file is long, but then it should probably be split up.)

@larsoner
Copy link
Contributor Author

Moved to the top!

@QuLogic QuLogic merged commit 8fa61a4 into matplotlib:master Sep 22, 2020
@larsoner larsoner deleted the test branch September 23, 2020 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants