Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Correctly remove support for \stackrel. #18533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 21, 2020
Merged

Correctly remove support for \stackrel. #18533

merged 3 commits into from
Sep 21, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 20, 2020

PR Summary

This was done incompletely in c4d3cd4 (3.3), after which \stackrel{x}{y}
just behaved (incorrectly) like xy.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.3.3 milestone Sep 20, 2020
@anntzer
Correctly remove support for \stackrel.
759351e 
This was done incompletely in c4d3cd4, after which `\stackrel{x}{y}`
just behaved (incorrectly) like `xy`.
timhoffm
timhoffm approved these changes Sep 20, 2020
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed test (azure py37) seeme unrelated.

@QuLogic QuLogic merged commit aa82b50 into matplotlib:master Sep 21, 2020
@lumberbot-app
Copy link

lumberbot-app bot commented Sep 21, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.3.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 aa82b50c349d3b8dcc6daac964aa06106aa1d0f6
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #18533: Correctly remove support for \\stackrel.'
  1. Push to a named branch :
git push YOURFORK v3.3.x:auto-backport-of-pr-18533-on-v3.3.x
  1. Create a PR against branch v3.3.x, I would have named this PR:

"Backport PR #18533 on branch v3.3.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@anntzer anntzer deleted the unstackrel branch September 22, 2020 07:37
QuLogic added a commit to QuLogic/matplotlib that referenced this pull request Oct 13, 2020
@QuLogic
Backport PR matplotlib#18533: Correctly remove support for \stackrel.
6818007
timhoffm added a commit that referenced this pull request Oct 14, 2020
@timhoffm
Merge pull request #18725 from QuLogic/auto-backport-of-pr-18533-on-v…
d270810 
…3.3.x

Backport PR #18533 on branch v3.3.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: text/mathtext
Projects
None yet
Milestone
v3.3.3
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @tacaswell @timhoffm @QuLogic