Support usetex in date Formatters #18558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is consistent with other files.
1b3fb63 to
de1cb4a
Compare
|
So currently, this just blanket modifies the resulting string to work in TeX mode, but I wonder if it should be more nuanced and change the formatters for only the numbers? |
|
This seems reasonable, but the tests aren't passing.... |
|
Ooops, that's because I set the default to |
de1cb4a to
d22d35e
Compare
tacaswell
approved these changes
Oct 14, 2020
|
I am inclined to merge this as-is because people still have the option of specifying the format strings as they wish (and not relying on us to auto-tex-ify them) and we can down down the route of trying to parse the dateformats and decide which should be strings and which are numbers that should be texified when someone asks for it. |
jklymak
approved these changes
Oct 14, 2020
|
Thanks for the nudge - I forgot about this.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
And some small cleanup.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).