Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix setting 0-timeout timer with Tornado. #18584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Sep 26, 2020

PR Summary

It doesn't allow 0, so set a very small minimum.

Fixes #18580.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

It doesn't allow 0, so set a very small minimum.

Fixes matplotlib#18580.
@jklymak jklymak merged commit 70c5f2b into matplotlib:master Sep 27, 2020
@dopplershift dopplershift added this to the v3.4.0 milestone Sep 28, 2020
@QuLogic QuLogic deleted the fix-tornado-timer branch September 28, 2020 22:48
@QuLogic
Copy link
Member Author

QuLogic commented Oct 13, 2020

This is a regression from 3.2.2.

@meeseeksdev backport to v3.3.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 13, 2020
@QuLogic QuLogic modified the milestones: v3.4.0, v3.3.3 Oct 13, 2020
QuLogic added a commit that referenced this pull request Oct 13, 2020
…584-on-v3.3.x

Backport PR #18584 on branch v3.3.x (Fix setting 0-timeout timer with Tornado.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Animation freezes in Jupyter notebook
4 participants