Deprecate MathTextParser("bitmap") and associated APIs. #18591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
commented
Sep 26, 2020
| self._mathtext_parser = mathtext.MathTextParser('bitmap') | ||
| img, _ = self._mathtext_parser.parse(lev, dpi=72, | ||
| prop=self.labelFontProps) | ||
| self._mathtext_parser = mathtext.MathTextParser('agg') |
There was a problem hiding this comment.
this specific use is going away via #16171.
8e370a2 to
0bc633b
Compare
|
It appears that |
|
You could wrap the call to |
|
Yes, that should go in the deprecation note, maybe as a longer example. |
|
done |
0bc633b to
ef15c5a
Compare
QuLogic
approved these changes
Oct 1, 2020
`MathTextParser("bitmap")` is rather low-level APIs to convert text
strings to images. Instead, one can use a much more generic method,
namely directly drawing to a new Figure() and saving with
`bbox_inches="tight"`. Alternatively, if one really wants a single
function call, there's still `mathtext.math_to_image`.
Also fix the wx example to use light text colors when so directed by the
system theme.
ef15c5a to
5ce4ff2
Compare
tacaswell
reviewed
Oct 1, 2020
| from matplotlib.transforms import IdentityTransform | ||
|
|
||
|
|
||
| def text_to_rgba(s, *, dpi, **kwargs): |
There was a problem hiding this comment.
Why not use math_to_image here?
tacaswell
approved these changes
Oct 1, 2020
|
Because it's a super-specialized API which I don't think is particularly interesting to demonstrate (or even to expose), whereas drawing on a figure and saving with tight bbox works for basically anything you may want to draw -- including text, but not only that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MathTextParser("bitmap")is rather low-level APIs to convert textstrings to images. Instead, one can use a much more generic method,
namely directly drawing to a new Figure() and saving with
bbox_inches="tight". Alternatively, if one really wants a singlefunction call, there's still
mathtext.math_to_image.Also fix the wx example to use light text colors when so directed by the
system theme.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).