Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Correctly sync state of wx toolbar buttons when triggered by keyboard. #18605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2020
Merged

Correctly sync state of wx toolbar buttons when triggered by keyboard. #18605

merged 1 commit into from
Sep 29, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 29, 2020

Previously, pressing "p" would unclick the "Pan" button if it was
already pressed, but not press it if it wasn't (even though it did
correctly start panning). Fix that.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer
Correctly sync state of wx toolbar buttons when triggered by keyboard.
07754f0 
Previously, pressing "p" would unclick the "Pan" button if it was
already pressed, but not press it if it wasn't (even though it did
correctly start panning).  Fix that.
dstansby
dstansby approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, I'm guessing there's no easy way to test this in the CI?

@dstansby dstansby added this to the v3.4.0 milestone Sep 29, 2020
@anntzer
Copy link
Contributor Author

anntzer commented Sep 29, 2020

I doubt so...

@dopplershift dopplershift merged commit 0daf9d7 into matplotlib:master Sep 29, 2020
@anntzer anntzer deleted the wxtb branch September 29, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
GUI: wx topic: toolbar
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @dopplershift @dstansby