Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Define GridFinder.{,inv_}transform_xy as normal methods. #18661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2020
Merged

Define GridFinder.{,inv_}transform_xy as normal methods. #18661

merged 1 commit into from
Oct 5, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Oct 5, 2020

... rather than as dynamical attributes using local functions.

This way they show up in the docs, and avoid making GridFinder
unpicklable.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer
Define GridFinder.{,inv_}transform_xy as normal methods.
66cc32a 
... rather than as dynamical attributes using local functions.

This way they show up in the docs, and avoid making GridFinder
unpicklable.
@QuLogic QuLogic merged commit 5f5fce3 into matplotlib:master Oct 5, 2020
@QuLogic QuLogic added this to the v3.4.0 milestone Oct 5, 2020
@anntzer anntzer deleted the gfp branch October 5, 2020 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
topic: mpl_toolkit
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @dopplershift @QuLogic