Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Also fix tk key mapping, following the same strategy as for gtk. #18693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2020
Merged

Also fix tk key mapping, following the same strategy as for gtk. #18693

merged 1 commit into from
Oct 10, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Oct 8, 2020

Some keys are still misreported, e.g. numpad keyreleases (keypresses are
fine), but I think this is already an improvement.

(followup to #17791)

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer anntzer added the GUI: tk label Oct 8, 2020
QuLogic
QuLogic requested changes Oct 9, 2020
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this fixes the number pad, it breaks the arrow keys.

@anntzer anntzer force-pushed the tkkeys branch 2 times, most recently from c133aa3 to 577f324 Compare October 9, 2020 07:45
@anntzer
Copy link
Contributor Author

anntzer commented Oct 9, 2020

good catch, now fixed. Also found that I needed to fix pageup/pagedown, done.

QuLogic
QuLogic approved these changes Oct 10, 2020
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work, but given the removed comments in the code, it might be nice to get someone on macOS to test.

@anntzer
Also fix tk key mapping, following the same strategy as for gtk.
57b9c26 
Some keys are still misreported, e.g. numpad keyreleases (keypresses are
fine), but I think this is already an improvement.
@anntzer
Copy link
Contributor Author

anntzer commented Oct 10, 2020

both comments handled, agreed physically testing on a mac would be nice.

@timhoffm timhoffm added this to the v3.4.0 milestone Oct 10, 2020
@timhoffm timhoffm merged commit 2ce4404 into matplotlib:master Oct 10, 2020
@anntzer anntzer deleted the tkkeys branch October 10, 2020 13:48
@anntzer anntzer mentioned this pull request Dec 20, 2020
Open
@anntzer anntzer mentioned this pull request Feb 25, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
GUI: tk
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @timhoffm