-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
removed glossary #18696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed glossary #18696
Conversation
One of the tutorials (I think introductory/usage? don't have time to look right now) uses the glossary. If those like 2 or 3 references get changed to links this will build. As usual will have much more time over the weekend. |
Hi @maria-ilie, thanks for taking care of this, and sorry for the terse response earlier. As you can see below, circleci is failing to build the docs, which is because there are secretly references to it hiding in As far as I can tell, this is the only file that uses these links so it would be more appropriate for the references to simply be added at the end of the file, as in the "external hyperlink targets" example here: https://docutils.sourceforge.io/docs/user/rst/quickref.html#external-hyperlink-targets Let me know if you need any more pointers! P.S. I recommend building the docs locally to make sure your changes worked correctly. If the |
Co-authored-by: Elliott Sales de Andrade <[email protected]>
@maria-ilie Thanks and congratulations on your first contribution to Matplotlib. We'd love to see you back! |
Thanks @timhoffm and @brunobeltran for your advice and for taking the time to review this pull request! |
PR Summary
Issue #18491 - Removed glossary file and mention of glossary in doc\contents.rst . I checked with grep and there were no other places mentioning glossary.
PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
andpydocstyle<4
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).