Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow setting default AutoMinorLocator #18715

Merged
tacaswell merged 11 commits intomatplotlib:mainfrom
IlievskiV:ndivs-minor-ticks
May 24, 2023
Merged

Allow setting default AutoMinorLocator #18715
tacaswell merged 11 commits intomatplotlib:mainfrom
IlievskiV:ndivs-minor-ticks

Conversation

@IlievskiV
Copy link
Contributor

@IlievskiV IlievskiV commented Oct 11, 2020 •
edited
Loading

PR Summary

Pull request to resolve #14233 - Allow setting default AutoMinorLocator.
This PR is related to PR #16762 which is stale for a while and seems to abandoned by the developer.
The behavior is similar to what is described in PR #16762 and Issue #14233 .
In this PR I include:

  • Validator of for the non-negative integers
  • Validator for the new rcParams option ndivs for the number of minor ticks
  • Automated tests for the new options

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@jklymak jklymak changed the title Allow setting default AutoMinorLocator #14233 Allow setting default AutoMinorLocator Oct 11, 2020
@IlievskiV
Copy link
Contributor Author

IlievskiV commented Oct 13, 2020

Is there anyone to review?

jklymak
jklymak reviewed Oct 14, 2020
View reviewed changes
jklymak
jklymak reviewed Oct 14, 2020
View reviewed changes
@jklymak
Copy link
Member

jklymak commented Oct 14, 2020

overall this looks great, just a couple of nitpicks. Please continue ping us if no one follows up...

@tacaswell tacaswell added this to the v3.4.0 milestone Oct 14, 2020
@jklymak
Copy link
Member

jklymak commented Oct 15, 2020

Very nice. We need a second review, so again don't hesitate to ping if no one gets to it in a couple of days.

QuLogic
QuLogic reviewed Oct 15, 2020
View reviewed changes
QuLogic
QuLogic reviewed Oct 16, 2020
View reviewed changes
@IlievskiV
Copy link
Contributor Author

IlievskiV commented Oct 21, 2020

@QuLogic is it fine now, or I have to update or add something else?

@jklymak jklymak requested a review from QuLogic October 21, 2020 14:33
@QuLogic
Copy link
Member

QuLogic commented Oct 22, 2020

This looks good, but one thing I should have asked earlier; can you add a What's new? entry for this?

@QuLogic
Copy link
Member

QuLogic commented Dec 2, 2020

Ping?

@IlievskiV
Copy link
Contributor Author

IlievskiV commented Dec 3, 2020

Here I am, I forgot about this :) Will add the documentation soon.

@QuLogic
Copy link
Member

QuLogic commented Jan 4, 2021

Ping again? We'd like to make 3.4 soonish, this month or so.

@jklymak
Copy link
Member

jklymak commented Feb 4, 2021

Lets move to 3.5. If we hear from the author in the next day or so we can move back...

@jklymak jklymak modified the milestones: v3.4.0, v3.5.0 Feb 4, 2021
@jklymak jklymak marked this pull request as draft May 8, 2021 23:32
@QuLogic QuLogic modified the milestones: v3.5.0, v3.6.0 Aug 23, 2021
@timhoffm timhoffm modified the milestones: v3.6.0, unassigned Apr 30, 2022
@story645 story645 modified the milestones: unassigned, needs sorting Oct 6, 2022
Vladimir and others added 11 commits May 12, 2023 23:20
@QuLogic QuLogic force-pushed the ndivs-minor-ticks branch from 0b0bab5 to 970938b Compare May 13, 2023 07:59
@QuLogic
Copy link
Member

QuLogic commented May 13, 2023

I've rebased and added a what's new note; might want to squash to fewer commits later.

@tacaswell tacaswell marked this pull request as ready for review May 24, 2023 19:48
@tacaswell tacaswell merged commit 6a323c0 into matplotlib:main May 24, 2023
@tacaswell
Copy link
Member

tacaswell commented May 24, 2023

Thank you @IlievskiV , congratulations on your first merged Matplotib PR 🎉 and apologies this took so long to make it through the review process.

I hope we hear from you again.

@QuLogic QuLogic modified the milestones: future releases, v3.8.0 May 24, 2023
@tacaswell tacaswell mentioned this pull request May 24, 2023
Closed
6 tasks
devRD pushed a commit to devRD/matplotlib that referenced this pull request Jun 5, 2023
@IlievskiV @QuLogic @devRD
Allow setting default AutoMinorLocator (matplotlib#18715)
57cf897 
Fixes matplotlib#14233


Co-authored-by: Vladimir <[email protected]>
Co-authored-by: Elliott Sales de Andrade <[email protected]>
melissawm pushed a commit to melissawm/matplotlib that referenced this pull request Jun 15, 2023
@IlievskiV @QuLogic @melissawm
Allow setting default AutoMinorLocator (matplotlib#18715)
7693d78 
Fixes matplotlib#14233


Co-authored-by: Vladimir <[email protected]>
Co-authored-by: Elliott Sales de Andrade <[email protected]>
@tacaswell tacaswell mentioned this pull request May 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jklymak jklymak jklymak approved these changes

@QuLogic QuLogic Awaiting requested review from QuLogic

Assignees

No one assigned

Labels

New feature status: orphaned PR topic: ticks axis labels

Projects

First Time Contributors
Status: Merged

Milestone

v3.8.0

Development

Successfully merging this pull request may close these issues.

Feature Request: Allow setting default AutoMinorLocator

6 participants

@IlievskiV @jklymak @QuLogic @tacaswell @story645 @timhoffm