Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove some unused tick private attributes. #18765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Oct 18, 2020

These privates attributes were used prior to c3f87d4 to coordinate with
the tick sub-components instantiation machinery, but now that ticks
subcomponents are immediately instantiated, the private attributes have
become unused.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer anntzer changed the title Remove some unused tick attributes. Remove some unused tick private attributes. Oct 18, 2020
These privates attributes were used prior to c3f87d4 to coordinate with
the tick sub-components instantiation machinery, but now that ticks
subcomponents are immediately instantiated, the private attributes have
become unused.
@QuLogic QuLogic added this to the v3.4.0 milestone Oct 19, 2020
@QuLogic
Copy link
Member

QuLogic commented Oct 19, 2020

Travis passed, but didn't post.

@QuLogic QuLogic merged commit 4fb84b4 into matplotlib:master Oct 19, 2020
@anntzer anntzer deleted the tickpriv branch October 19, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants