You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But also, since edgecolors is an explicit argument name in scatter, I think it can never appear in kwargs. So I wonder why this is even done...
You're right, it can't. But it's also not checked or documented to be in kwargs. The code is edgecolors = kwargs.pop('edgecolor', edgecolors). Note the singular / plural in pop().
You're right, it can't. But it's also not checked or documented to be in kwargs. The code is edgecolors = kwargs.pop('edgecolor', edgecolors). Note the singular / plural in pop().
Ah you're right. I knew I looked at this before, and didn't change it for some reason, but missed the plurality again.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Precedence of edgecolor and edgecolors in scatter() documentation was incorrect. This changes the documentation to match the observed precedence.
Issue #18392
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).