DOC Use 'Axes' in _axes.py docstrings #18806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Oct 25, 2020
lib/matplotlib/axes/_axes.py
Outdated
| typically used for matrices and images. | ||
|
|
||
| Note that the vertical axes points upward for 'lower' | ||
| Note that the vertical Axes points upward for 'lower' |
There was a problem hiding this comment.
Actually this should have been a singular:
Suggested change
| Note that the vertical Axes points upward for 'lower' | |
| Note that the vertical axis points upward for 'lower' |
There was a problem hiding this comment.
Thank you, I should have caught that!
timhoffm
approved these changes
Oct 26, 2020
|
Thanks @lucyleeow! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
jeromefv
pushed a commit
to jeromefv/matplotlib
that referenced
this pull request
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Towards #18726
Use Axes instead of axes in
_axes.py.PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).