Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Change LogFormatter coeff computation #18812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2020

Conversation

pmli
Copy link
Contributor

@pmli pmli commented Oct 26, 2020

PR Summary

Changes coeff computation in LogFormatter.__call__, LogFormatterMathtext.__call__, and LogFormatterSciNotation to avoid underflow/overflow and adds a simple test.

Closes #18800.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@tacaswell tacaswell added this to the v3.4.0 milestone Oct 26, 2020
@jklymak jklymak merged commit 0163d0d into matplotlib:master Oct 26, 2020
@jklymak
Copy link
Member

jklymak commented Oct 26, 2020

Thanks @pmli OTOH, the general warning to not expect floating point miracles still stands 😉

@pmli pmli deleted the logformatter-coeff-edit branch October 27, 2020 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log-scale ticker fails at 1e-323
3 participants