-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Move from @cbook.deprecated to @_api.deprecated #18823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Mostly looking okay, but you have many missing references. |
Actually, no not okay, |
51444ba
to
be20463
Compare
be20463
to
47f73d7
Compare
Why not just Don't really have a strong opinion here but I figure you've given it some thought so wanted to know. |
I'm a bit paranoid by now concerning semi-public API. Importing Also, I don't want to import the specific functions (check_in_List, warn_deprecated, make_keyword_only, rename_parameter, ...) and remove the imports when they expire. That's a big back and forth adapting of the imports. One could even consider inlining the deprecation module into _api, but for now I'd leave it as a sub module. Furthermore, I like the _api prefix indicating the context. For example it makes it immediately clear, that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm convinced by the argument that everything should live under _api
. At that point, I would honestly prefer if everything was just inlined into _api
directly (especially since I'm about to move one random function into _api.deprecation
just to avoid circular imports (#18817)), but it doesn't seem like doing it this way for now fundamentally hurts our ability to do differently moving forward so...it'd be good to get this in.
PR Summary
Follow-up to #18657, which moved the functions. This PR now starts to move their usages in our code base.